fix: handle invalid JSON in semgrep parser and add unit tests#1741
Open
vedasingh00-rgb wants to merge 2 commits into
Open
fix: handle invalid JSON in semgrep parser and add unit tests#1741vedasingh00-rgb wants to merge 2 commits into
vedasingh00-rgb wants to merge 2 commits into
Conversation
utksh1
requested changes
Jul 9, 2026
utksh1
left a comment
utksh1
left a comment
Owner
There was a problem hiding this comment.
The semgrep JSON-handling fix and tests look good, but the branch has merge conflicts. Please rebase on latest main and push again — should be straightforward to land after that.
utksh1
added
level:intermediate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the semgrep_scanner parser to handle invalid JSON gracefully instead of silently ignoring errors. Added unit tests to verify all three scenarios — valid JSON, invalid JSON, and mixed stdout output.
Related Issues
#1421
Type of Change
How Has This Been Tested?
Added 3 unit tests in testing/test_semgrep_parser.py and ran them using pytest:
test_valid_json — verifies valid Semgrep JSON is parsed correctly
test_invalid_json — verifies invalid JSON does not crash the parser
test_mixed_stdout — verifies mixed stdout is handled gracefully
Checklist